0age
Follow
Pinned
1,497 contributions in the last year
Contribution activity
June 2022
Created 300 commits in 2 repositories
Created a pull request in ProjectOpenSea/seaport that received 8 comments
Recipient field and enhanced tests
This PR contains an interface change to fulfillAdvancedOrder and fulfillAvailableAdvancedOrders: it adds a recipient parameter that the fulfiller c…
+2,653
−2,123
•
8
comments
Opened 33 other pull requests in 3 repositories
ProjectOpenSea/seaport
29
merged
1
open
1
closed
- update deployment addresses
- include 1.1 contributors list in Seaport natspec
- run one final comment pass over the token transferrer
- implement nits from readthrough
- move Invalid1155BatchTransferEncoding to TokenTransferrerErrors.sol
- remove fixed gas on ecrecover precompile call
- perform some comment clarification and formatting cleanup
- bump up to 19066 runs
- Seaport 1.0 => 1.1
- update forge tests that somehow slipped through the cracks
- move modifier to top of contract
- ensure that basic order type is within range
- Optimize apply fraction
- Mingwatch gas optimization 1
- protect against dirty values in unused item params
- perform overflow check on first fill
- Optimize order status storage ptr
- fix reference to Counterd
- fail fast on batch 1155 and do a general cleanup pass
- bump from version 1.0 to version 1.1
- fix error in SignatureVerification natspec
- fix dirtied bits past contract name length
- adhere to 80-char lines in contracts/ & add an unchecked
- rename nonce to counter
- Add contributors
- Some pull requests not shown.
OpenSeaProtocol/seaport
1
merged
ProjectOpenSea/marketplace-benchmarks
1
merged
Reviewed 35 pull requests in 2 repositories
ProjectOpenSea/seaport
25 pull requests
- Add helper contracts and tests for obtaining an order hash and a digest
- Updates reference implementation to match #474
- Zones 1.1
- [WIP] Address TransferHelper comments
- Seaport 1.0 => 1.1
- Add Foundry test for failures when spending pre-approved items from null address with invalid signature
-
⚡️ AmountDeriver: optimize roundUp -
added a compile hook for
hardhat-vyperplugin - Add transfer helper
- cache array lengths in OrderFulfiller for gas optimization
- Add invalid length fulfill order tests
- ReferenceSeaport renaming
- perform overflow check on first fill
- Recipient field and enhanced tests
-
Gas opt: skip
remainingcalculation when not necessary - Add contributor and some small stuff
- Optimize gas for _getFraction in AmountDeriver
- some small changes.
- Add tests for fulfill basic order with invalid length for additional recipients
- standardize array length caching
-
Update
CONTRIBUTORS.mdand fix TYPO - 80 is the way
-
Minor optimization for testing
vis valid for signature verification. - Optimize orderStatus as storage pointer
- Fix typos & Update CONTRIBUTORS.md
- Some pull request reviews not shown.