Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue hooks and examples of usage #19

Merged
merged 9 commits into from Sep 12, 2023
Merged

Vue hooks and examples of usage #19

merged 9 commits into from Sep 12, 2023

Conversation

letehaha
Copy link
Contributor

@letehaha letehaha commented Sep 7, 2023

Closes SNS-34

@letehaha letehaha added the enhancement New feature or request label Sep 7, 2023
@letehaha letehaha self-assigned this Sep 7, 2023
@letehaha letehaha requested a review from dr497 September 11, 2023 19:19
@letehaha letehaha marked this pull request as ready for review September 11, 2023 19:19
@@ -0,0 +1,8 @@
import { createApp } from 'vue'
import './style.css'
import App from './app.vue'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import App from './app.vue' should import App from './App.vue'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now, as well with the styles

@dr497
Copy link
Contributor

dr497 commented Sep 12, 2023

The current vue-app has a white text color on a white background for the input fields which makes it difficult to read

@letehaha letehaha requested a review from dr497 September 12, 2023 07:36
@dr497 dr497 merged commit 104d7b1 into main Sep 12, 2023
@dr497 dr497 deleted the feat/vue-hooks branch September 12, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants