Update CommandPost Overlays in Final Cut Pro to make use of FCPX Custom Overlays #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stent file and then updates the the new value. This doesn't work when disabling the overlay, which still requires a viewer update to refresh. * Simplified the API down to a Viewer/EventViewer 'overlay enabled' function, and retrieving the selected `overlay` for the particular viewer. * While the whole API can be accessed via CustomOverlay, most will provbably access via the Viewer props (isOverlayEnabled/overlay/userOverlays)
…r more accurate display #2719* * Currently very broken * Partially working: - Draggable Guides as multiple canvases * Not working: - Overlays - Transparency on anything * Also, some wicked bad lag when initially loading CP (on my machine). Still determining if this is due to code in this branch or CP overall.
latenitefilms
changed the title
|
@randomeizer - With this one, given it's been a while, maybe we should tweak this pull request so that we can merge in the new FCPX API bits, but not actually break the existing overlays plugin? Move this new overlay plugin into a "V2" folder or something, but have it disabled for now until we eventually go back and finish it off? |
|
Currently fails with: CommandPost v1.4.6 (Build: 7380)
Build Date: Aug 11 2022, 12:55:15
macOS Version: 12.4.0
CommandPost Locale: en_AU
Current Keyboard Layout: Australian
Final Cut Pro Path: /Applications/Final Cut Pro.app
Final Cut Pro Version: 10.6.4
Final Cut Pro Language: en
Developer Mode: true
2022-08-13 23:09:56: 2022-08-13 23:09:54: -- Loading /Users/chrishocking/Documents/GitHub/CommandPost/src/extensions/cp/init.lua
2022-08-13 23:09:56: 23:09:56 cp: Loading Plugins...
2022-08-13 23:09:56: 23:09:56 ERROR: plugins: Unable to load plugin '/Users/chrishocking/Documents/GitHub/CommandPost/src/plugins/finalcutpro/viewer/overlays/init.lua' due to the following error:
...c/plugins/finalcutpro/viewer/overlays/DraggableGuide.lua:84: attempt to index a nil value (field 'fullScreenWindow')
stack traceback:
...c/plugins/finalcutpro/viewer/overlays/DraggableGuide.lua:84: in main chunk
[C]: in function 'dofile'
...ts/GitHub/CommandPost/src/extensions/cp/plugins/init.lua:859: in function 'require'
...andPost/src/plugins/finalcutpro/viewer/overlays/init.lua:11: in main chunk
[C]: in function 'dofile'
...ts/GitHub/CommandPost/src/extensions/cp/plugins/init.lua:791: in function <...ts/GitHub/CommandPost/src/extensions/cp/plugins/init.lua:791>
[C]: in function 'xpcall'
...ts/GitHub/CommandPost/src/extensions/cp/plugins/init.lua:791: in function 'cp.plugins.loadSimplePlugin'
...ts/GitHub/CommandPost/src/extensions/cp/plugins/init.lua:875: in function 'cp.plugins.loadComplexPlugin'
...ts/GitHub/CommandPost/src/extensions/cp/plugins/init.lua:750: in function 'cp.plugins.scanDirectory'
...ts/GitHub/CommandPost/src/extensions/cp/plugins/init.lua:768: in function 'cp.plugins.scanDirectory'
...ts/GitHub/CommandPost/src/extensions/cp/plugins/init.lua:768: in function 'cp.plugins.scanDirectory'
...ts/GitHub/CommandPost/src/extensions/cp/plugins/init.lua:768: in function 'cp.plugins.scanDirectory'
...ts/GitHub/CommandPost/src/extensions/cp/plugins/init.lua:684: in function 'cp.plugins.init'
.../Documents/GitHub/CommandPost/src/extensions/cp/init.lua:324: in function <.../Documents/GitHub/CommandPost/src/extensions/cp/init.lua:53>
(...tail calls...)
[C]: in function 'xpcall'
...ents/GitHub/CommandPost/src/extensions/hs/_coresetup.lua:831: in function 'hs._coresetup.setup'
(...tail calls...)
2022-08-13 23:10:00: 23:10:00 ** Warning: plugins: Slow Plugin: core.touchbar.virtual (2.1422789096832)
2022-08-13 23:10:00: 23:10:00 ** Warning: plugins: Slow Plugin: finalcutpro.touchbar.virtual (2.1472311019897)
2022-08-13 23:10:00: 23:10:00 ERROR: plugins: Attempted to initialise non-existent plugin: finalcutpro.viewer.overlays
2022-08-13 23:10:00: 23:10:00 ERROR: plugins: Unable to load dependency for plugin 'finalcutpro.tangent.overlay': finalcutpro.viewer.overlays
2022-08-13 23:10:05: 23:10:05 ** Warning: plugins: Slow Plugin: finalcutpro.setup.scan (3.0868289470673)
2022-08-13 23:10:07: 23:10:07 ** Warning: plugins: Slow Plugin: core.menu.menuaction (1.3294310569763)
2022-08-13 23:10:07: 23:10:07 ERROR: plugins: Unable to post-initialise 'finalcutpro.tangent.overlay': expected status of "initialized" but is "error"
2022-08-13 23:10:07: cp: Plugins Loaded.
2022-08-13 23:10:07: Startup Time: 7.099813 seconds
2022-08-13 23:10:07: Garbage Collection Mode: generational
2022-08-13 23:10:07: -- Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now uses the 'video image' for dimensions/location