Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored MRT_TabelBodyRow to CSS module #132

Merged
merged 3 commits into from Sep 22, 2023
Merged

Refactored MRT_TabelBodyRow to CSS module #132

merged 3 commits into from Sep 22, 2023

Conversation

alessandrojcm
Copy link
Contributor

@alessandrojcm alessandrojcm commented Sep 22, 2023 •
edited

  • Added typescript module support (let me know if it's not necessary, I was getting typing errors otherwise)
  • Refactored MRT_TabelBodyRow to CSS Modules, used clsx to allow the classnames to be overwritten. Same as above, let me know if that's not required an I'll remove it

@vercel
Copy link

vercel bot commented Sep 22, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @KevinVandy on Vercel.

@KevinVandy first needs to authorize it.

KevinVandy
KevinVandy requested changes Sep 22, 2023
View reviewed changes
Copy link
Owner

@KevinVandy KevinVandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly the right idea, but I don't think I want to be changing the folder structure of the MRT components

@alessandrojcm
Copy link
Contributor Author

I think this is mostly the right idea, but I don't think I want to be changing the folder structure of the MRT components

Cool, should I just move the CSS file and the component code up a folder then?

@alessandrojcm alessandrojcm changed the title Refactores MRT_TabelBodyRow to CSS module Refactored MRT_TabelBodyRow to CSS module Sep 22, 2023
@KevinVandy KevinVandy merged commit 06e604b into KevinVandy:v2 Sep 22, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinVandy KevinVandy KevinVandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alessandrojcm @KevinVandy