Toggle row action menu #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @KevinVandy on Vercel. @KevinVandy first needs to authorize it. |
KevinVandy
requested changes
Sep 22, 2023
| @@ -16,6 +19,7 @@ export const MRT_ToggleRowActionMenuButton = < | |||
| cell, | |||
| row, | |||
| table, | |||
| className, | |||
There was a problem hiding this comment.
Small thing, class name needs to only come from mantineProps, not the literal props of this internal component
There was a problem hiding this comment.
Is there a mantineProps for this component? Can't seem to find it
KevinVandy
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
styleprop fromHTMLPropsRefas theMantineStylePropsalready hasCSSPropertiesas part of its union type, this was causing type errors. Not sure about this so let me know if it's not correct