Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix filtering bug when filterFromLeafRows = true #5049

merged 1 commit into from Sep 6, 2023


Copy link

@retnag retnag commented Sep 1, 2023

I believe there is an obvious typo in the filterRowsUtils.ts::filterRowModelFromLeafs, causing the filteredRowModel.flatRows to always be empty, and also column.uniqueFacetedValues() to be an empty array (which is what tipped me off). There was no execution path, where the newFilteredRowsById array gets populated.

fixes: #4768

@KevinVandy KevinVandy merged commit 1049c20 into TanStack:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Faceted Unique Values is empty when filterFromLeafRows is set
2 participants